https://bugzilla.redhat.com/show_bug.cgi?id=2248952 --- Comment #2 from Tom Rix <trix@xxxxxxxxxx> --- The big issue I have found is the upstream project has binaries checked into its repo. https://github.com/intel/ittapi/blob/master/include/fortran/posix/x86/advisor_annotate.o Everything in fedora must be built from fedora. smaller issues The soversion is defined in the patch, update the patch to match the release new directories need a %dir <new dir> It would be nice to have %check So I can verifiy it works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2248952 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248952%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
