https://bugzilla.redhat.com/show_bug.cgi?id=2251523 --- Comment #11 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > The library is header-only, so I think it does not contain the debug information. I never reviewed a package like this one. I checked with another maintainer and it seems correct. > I see that there is third-party catch2 library in the source code of libheinz, which is https://jugit.fz-juelich.de/mlz/libheinz/-/blob/main/test/catch.hpp. And I look through the license policy of Fedora packaging, so I think it should add the license of catch2 to license field and mark it as bundled. Good catch. You are correct about the license. I would not be so strict about providing the bundles(catch2). It seems to me that in the bundle only some parts of the code. But it will do no harm either. > For the patch issue, the upstream maintainer says, As it happens, we are currently reviewing CMake installation commands, starting with some other libraries. Therefore please allow for some time before we come back to libheinz and to your patch. So I add the link of issue and some comments to explain what the patch do for now. Yes. That is ok. Even if upstream would reject this patch then simple leaving the comment with link to the issue is reference that you tried and as pointer for anyone wondering why the patch is there. When upstream merged your PR, you can remove this part later. The spec file looks good now. With the exception of summary. You do not need to wait on upstream to come with better description. You can write something yourself. As part of sponsoring you I want to explain you the processes in Fedora. I see you are in Singapore TZ. Will you be available for about an hour long talk? Some morning of your local time? Maybe this Friday? I can sent you an invite to GMeet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2251523 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251523%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
