https://bugzilla.redhat.com/show_bug.cgi?id=2251096 --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the review! (In reply to Benson Muite from comment #5) > Comments: > a) Builds on all architectures: > https://koji.fedoraproject.org/koji/taskinfo?taskID=109416923 > b) Might update changelog comment to indicate it is for unretirement The package used to use rpmautospec before unretirement, so the changelog message right now will be thrown away anyway when I import it. > c) The directories > /usr/share/locale/mo, /usr/share/locale/mo/LC_MESSAGES > have no owners. Is this a bug in %find_lang %{appname} ? No, it's not a bug in %find_lang, it's a bug in the filesystem package: https://bugzilla.redhat.com/show_bug.cgi?id=2251577 > d) SVG icons usually go in /usr/share/icons/hicolor/scalable Not necessarily. These ones are size-specific, but provided in a vector graphics format. The non-"scalable" icons don't *have* to be in bitmap formats. > e) Can tests be run? Yes. I added `%meson_test` to the %check section and tests pass in a local build. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251096 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251096%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
