https://bugzilla.redhat.com/show_bug.cgi?id=2246560 Kate Hsuan <hpa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hpa@xxxxxxxxxx --- Comment #2 from Kate Hsuan <hpa@xxxxxxxxxx> --- Thank you for working on it. I’ve started to work on reviewing it. I’ve tried to build the package and list various things that need to be changed. Please prepare a new version that addresses the things listed below. 1. Please use white spaces as the blank spaces and make sure the format of the label and value are aligned. For example: License: GPL-2.0-or-later URL: https://github.com/intel/intel-lpmd Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz # https://github.com/intel/intel-lpmd/pull/13 Patch0: 13.patch ExclusiveArch: x86_64 BuildRequires: autoconf BuildRequires: automake 2. The newline after “Summary:” can be removed. 3. The %build does not rely on ./configure innovation done by autogen.sh. Generating configure should be done in %prep section. Look at the autogen.sh. It consists of “aclocal --install”, “gtkdocize --copy --flavour no-tmpl”, and “autoreconf --install --verbose”. So put these three lines in the %prep section after %autosetup, the ./configure will not be run in the %perp section. %prep %autosetup -p1 aclocal --install gtkdocize --copy --flavour no-tmpl autoreconf --install --verbose %build %configure %make_build 4. I also noticed that the package requires dbus-glib. “BuildRequires: dbus-glib-devel” As far as I know, dbus-glib is going to be deprecated. The better way is to use the GDBus as the DBus backend for lpmd. Could you please switch to GDBus? The information can be found at https://dbus.freedesktop.org/doc/dbus-glib/. Thank you. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246560 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246560%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
