https://bugzilla.redhat.com/show_bug.cgi?id=2250496 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Flags| |fedora-review? CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There's a couple things in this crate that are potentially problematic, and likely can't be shipped in this form (from "worst" problem to "least bad"): - The code in src/data/*.rs appears to have been generated from Unicode data. In most circumstances, that means the generated code is licensed under the terms of the Unicode-DFS-2016 license. The code only has a generic "this is generated, do not edit" header, but doesn't state *what* the code was generated *from*. If it is indeed the case that it was generated from Unicode data, the crate's license metadata in Cargo.toml metadata must be amended to "(MIT OR Apache-2.0) AND Unicode-DFS-2016" (similar to what the https://crates.io/crates/unicode-ident crate does). Additionally, the crate would need to carry the actual Unicode license text (see also the GitHub project for the unicode-ident crate). You will likely need to ask the upstream project for clarification on these points. - The resources in "resources/benchmark-texts" are covered under a variety of licenses (Project Gutenberg, CC-BY-SA 3.0, Apache-2.0, Unicode, ...), not all of which are always permissible for package contents. I think at the very least, the texts from Project Gutenberg need to be expunged from the package entirely (i.e. a "cleaned" source tarball needs to be created without these files), since it is likely that Fedora is not allowed to distributed these files. It appears that these files are only read by benchmarks, so the "resources" directory should be removable without affecting the functionality of the crate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2250496 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202250496%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
