https://bugzilla.redhat.com/show_bug.cgi?id=2249418 --- Comment #15 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- Spec URL: https://nphilipp.fedorapeople.org/review/jack-example-tools/6/jack-example-tools.spec SRPM URL: https://nphilipp.fedorapeople.org/review/jack-example-tools/6/jack-example-tools-4-1.fc40.src.rpm (In reply to Benson Muite from comment #14) > Comments: > a) Sorry for the delay. No problem! > b) In the spec file, please replace: > Source0: > https://github.com/jackaudio/%{name}/archive/refs/tags/%{version}.tar.gz > by > Source0: > https://github.com/jackaudio/%{name}/archive/v%{version}/%{name}-%{version}. > tar.gz > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_commit_revision Done. > c) The package does not seem to have any tests, so can remove > %meson_test I’d rather leave it in, so if tests get added to the package they will be run. > d) LGPL license may also be needed: > GNU Lesser General Public License v2.1 or later > ----------------------------------------------- > jack-example-tools-4/example-clients/internal_metro.h This is only used in internal_metro.cpp which is GPLv2. > jack-example-tools-4/example-clients/midi_latency_test.c 👍 > e) Please report old FSF address to upstream: > No copyright* GNU General Public License v2.0 or later [obsolete FSF postal > address (Mass Ave)] > ----------------------------------------------------------------------------- > ------------------- > ... > GNU General Public License v2.0 or later [obsolete FSF postal address (Mass > Ave)] > ----------------------------------------------------------------------------- > ---- > ... https://github.com/jackaudio/jack-example-tools/pull/83 > f) In the spec file, please replace > Requires: %{name}-common%{?_isa} = %{version}-%{release} > by > Requires: %{name}-common = %{version}-%{release} > This should enable installation as the package is a noarch package 👍 > g) Some warnings from getaddrinfo patch in the build log: > ../tools/netsource.c: In function ‘process’: > ../tools/netsource.c:314:83: warning: passing argument 5 of ‘netjack_sendto’ > from incompatible pointer type [-Wincompatible-pointer-type > s] > ... Oops, my previously submitted patch was unfinished, I’ve fixed it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249418 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249418%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
