https://bugzilla.redhat.com/show_bug.cgi?id=2244809 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #10 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #8) > > I was just curious. But since you are using a commit, I have the following to remark: > > Version 0.3.3, as published on PyPI, appears to be commit d5ec8cd0530967b9281af4ea17a00ecd68d20c88 [1] looking at what changed and the date of publication. > > It depends. The usual suggested practice is to make a release, and then > immediately bump the version so that if someone installs from source, they > get the new unreleased version that doesn't clash with the pypi released > version. So, it's hard to tell what commit they've released from here---it > could be any commit after they bumped to 0.3.3. Luckily, there's only one > commit after the one that bumps the release, and it's a cosmetic change to > the readme, so no harm including it too. > > https://github.com/alyakin314/lqrt/commits/master Okay. It wasn't a blocker to begin with. I suppose you are right. There are different strategies to approaching the version bump and without a specific tag that can be distilled from the PyPI release, we just don't know for sure. Package looks good now. APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244809 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244809%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
