[Bug 2250477] Review Request: granite-7 - Extend GTK with common widgets and utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2250477



--- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
I didn’t do a full review on this (or I would have assigned it to myself), but
I did notice that the file lib/Services/AsyncMutex.vala is GPL-3.0-or-later,
which is missing from the License expression.

> The only issue is that you're missing a "BuildRequires: gcc", which you can add on import.

It might be OK to rely on gcc being a transitive dependency of vala for a
pure-Vala package like this, but there’s certainly no harm in adding it
explicitly.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2250477

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202250477%23c9
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux