https://bugzilla.redhat.com/show_bug.cgi?id=2242903 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Rich! (In reply to Richard W.M. Jones from comment #2) > ocaml-ptime.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/ocaml/ptime/ptime_top_init.ml > > This probably should go into the -devel subpackage? Or be removed > during the %install? Actually, files with names of the form <module>_top_init.ml have to go into the main package for the top level to work. Maybe using the top level should be considered a "devel" sort of thing to do. I'm not sure. But you don't need any other devel files for the top level to work, so I figured these should go into the main package. (And note that the *_top_init.ml files are typically not compiled.) If you look at the ocaml package, the ocaml_files.py file has a function named "is_devel_file", used to determine whether files should go into the main package or the devel package. I put an explicit exemption in there for *_top_init.ml files for this reason. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2242903 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242903%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue