[Bug 2250700] Review Request: python-bioread - Utilities to read BIOPAC AcqKnowledge files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2250700



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Ankur Sinha (FranciscoD) from comment #2)
> Looks good. My only query is about the extras packages---they're all arched
> and I don't supposed there's a way of making them noarch? It doesn't really
> matter, just that rpmlint picks up the lack of binaries in them.

I think that there is no way of doing this for an arched base package other
than defining them manually without the assistance of
%pyproject_extras_subpackage. I’ve sometimes found that necessary in order to
do unusual things like adding upgrade paths for old subpackages, but it doesn’t
seem worth it just for making them noarch. This limitation is alluded to from a
different perspective in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_extras_macros:

> Due to technical limitations, the macro never generates requirements on the arched BASE_PACKAGE%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}. It only adds Requires: BASE_PACKAGE = %{?epoch:%{epoch}:}%{version}-%{release}) because a macro cannot reliably detect if the subpackage is arched or not. So far, this has not been a problem in practice.

However, the fact that the base package is arched is copied from another
package I used as a template, and it’s probably unnecessary for this package.
Certainly, the comment about endian-dependent test failures is not accurate for
this package. Try this:

New Spec URL: https://music.fedorapeople.org/20231121/python-bioread.spec
New SRPM URL:
https://music.fedorapeople.org/20231121/python-bioread-3.0.1-1.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2250700

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202250700%23c3
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux