https://bugzilla.redhat.com/show_bug.cgi?id=2244809 --- Comment #7 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #5) > Sorry for the delay! Here's the updated spec/srpm: > > Spec URL: https://ankursinha.fedorapeople.org/python-lqrt/python-lqrt.spec > SRPM URL: > https://ankursinha.fedorapeople.org/python-lqrt/python-lqrt-0.3.3-2. > 20231018gite2c250d.fc40.src.rpm The SRPM URL is a 404. That's why the the Fedora Review Service build failed. > > => Building from master. I suppose the actual release happens after the paper is published / approved? > > This isn't compulsory, but it depends on the individual here. They have > versioning in the code, they just haven't tagged on git/pypi somehow. I was just curious. But since you are using a commit, I have the following to remark: Version 0.3.3, as published on PyPI, appears to be commit d5ec8cd0530967b9281af4ea17a00ecd68d20c88 [1] looking at what changed and the date of publication. Since this is then the same as version 0.3.3 on PyPI, you probably wanna add the following to the spec file: # Don't use commit in dist tag %global distprefix %{nil} That will get rid of the commit in %dist. That's what I've been doing for `autograd` [2] as well, where the PyPI sdist is missing stuff. [1] https://github.com/alyakin314/lqrt/commit/d5ec8cd0530967b9281af4ea17a00ecd68d20c88 [2] https://src.fedoraproject.org/rpms/python-autograd/pull-request/5#request_diff -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244809 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244809%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
