Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: iputils https://bugzilla.redhat.com/show_bug.cgi?id=225909 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(mnagy@xxxxxxxxxx) ------- Additional Comments From panemade@xxxxxxxxx 2008-01-14 22:45 EST ------- 1)MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. 2) Follow initscript scriptlet as given at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-b638e19c644263af59762a3154a60554a8303bb3 missing Requires(preun): /sbin/service and Requires(postun): /sbin/service 3)Wherever applicable please keep timestamp from files being copied from upstream tarball. see http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab 4)Also, good to follow parallel make as given at http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e SHOULD: 1)If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review