https://bugzilla.redhat.com/show_bug.cgi?id=2154514 Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dridi.boukelmoune@xxxxxxxxx --- Comment #9 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- May I suggest taking some inspiration from my local packaging of hare? As of today it looks like this: https://github.com/Dridi/dotfiles/blob/523fb5317185ce3da586ff82639e67de674cd6af/rpmbuild/SPECS/hare.spec I solved the cross-compiling configuration and dependencies with Lua macros: https://github.com/Dridi/dotfiles/blob/523fb5317185ce3da586ff82639e67de674cd6af/rpmbuild/SPECS/hare.spec#L37-L45 https://github.com/Dridi/dotfiles/blob/523fb5317185ce3da586ff82639e67de674cd6af/rpmbuild/SPECS/hare.spec#L67-L104 I also meant to make the qbe package install an RPM macro %{qbe_arches}: https://github.com/Dridi/dotfiles/blob/523fb5317185ce3da586ff82639e67de674cd6af/rpmbuild/SPECS/hare.spec#L47-L48 But I did the work for my hare package: https://github.com/Dridi/dotfiles/blob/523fb5317185ce3da586ff82639e67de674cd6af/rpmbuild/SPECS/hare.spec#L114-L121 The harec package should probably also expose a %{harec_arches} macro. I also tried to extract linker flags from GCC LDFLAGS to feed the LDLINKFLAGS variable: https://github.com/Dridi/dotfiles/blob/523fb5317185ce3da586ff82639e67de674cd6af/rpmbuild/SPECS/hare.spec#L5-L13 It appears to work on my machine, but probably needs scrutiny. There are other things to consider and off the top of my head I remember wanting to look at tzdata integration and never did. Adding this is probably enough: Requires: /usr/share/zoneinfo/leap-seconds.list One strong recommendation I have is to separate the hare toolchain from the standard library. They have different licenses and purposes so that small complication simplify other things. I tried to submit a patch upstream to make it easier to process module dependencies to add this to packaging, but my patch was conflicting with major ongoing refactoring, and until qbe and harec become recent-enough on my machine, I won't attempt a new patch. Right now my old rig is functional for my hare usage. Hare packaging is currently not on my radar but I may remember other things now that it was brought up to my attention. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2154514 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202154514%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
