[Bug 2249637] Review Request: libtbox - A glib-like multi-platform c library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2249637

Zephyr Lykos <fedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(topazus@outlook.c
                   |                            |om)



--- Comment #16 from Zephyr Lykos <fedora@xxxxxxxxx> ---
Some misc. changes.
- Style changes (optional)
- The demo executable is required for %check, but not required in distribution
- Use more neutral wording in Summary and Description
- Add feature flags for xmake
- Add relwithdebinfo build mode to export debuginfo

--- tbox.spec           2023-11-17 21:52:40.250583881 +0800
+++ libtbox.spec        2023-11-17 21:51:11.349633496 +0800
@@ -1,50 +1,45 @@
-%global debug_package %{nil}
-%global sover 1
+Name:       libtbox
+Version:    1.7.5

 %global forgeurl https://github.com/tboox/tbox
-Version:        1.7.5
+
 %forgemeta

-Name:           libtbox
-Release:        %autorelease
-Summary:        A glib-like multi-platform c library
-
-# The library is mainly under Apache-2.0 license, except:
-# src/tbox/platform/arch/{arm,arm64,mips,x86,x64}/context.{S,asm}: BSL-1.0
-# src/tbox/hash/adler32.c: Zlib
-License:        Apache-2.0 AND BSL-1.0 AND Zlib
-URL:            %{forgeurl}
-Source0:        %{forgesource}
-Patch0:         0001-build-fix-DESTDIR.patch
+Release:    %autorelease
+Summary:    Portable toolbox library with great cross-platform support

-BuildRequires:  gcc
-BuildRequires:  make
+# Library and 3rd-party modules licensing:
+# * tbox - Apache-2.0 -- Main tarball;
+# * src/tbox/platform/arch/*/context.{S,asm} - BSL-1.0 -- static dependency;
+# * src/tbox/hash/adler32.c -- Zlib -- static dependency.
+License:    Apache-2.0 AND BSL-1.0 AND Zlib
+URL:        https://tboox.org
+Source:     %{forgesource}

-%description
-TBOX is a glib-like cross-platform C library that is simple to use yet
powerful
-in nature.
+Patch0:     0001-build-fix-DESTDIR-add-relwithdebinfo.patch

-The project focuses on making C development easier and provides many modules
-(.e.g stream, coroutine, regex, container, algorithm ...), so that any
developer
-can quickly pick it up and enjoy the productivity boost when developing in C
-language.
+BuildRequires:  pkgconfig(ncurses)
+BuildRequires:  pkgconfig(liblz4)
+
+BuildRequires:  bash
+BuildRequires:  make
+BuildRequires:  gcc
+BuildRequires:  gcc-c++

-It supports the following platforms: Windows, Macosx, Linux, Android, iOS,
*BSD
-and etc.
+%description
+A feature-packed, embedded friendly toolbox library.
+Think of stdlib for embedded systems or Boost for C.
+Provides stream, coroutine, regex, container, algorithm and more modules.

-%package        devel
+%package devel
 Summary:        Development files for %{name}
 Requires:       %{name}%{?_isa} = %{version}-%{release}

-%description    devel
-The %{name}-devel package contains libraries and header files for developing
-applications that use %{name}.
+%description devel
+This package contains headers and development files for %{name}.

 %prep
 %forgeautosetup -p1
-
-chmod -x README.md LICENSE.md
-
 cat > %{name}.pc << EOF
 prefix=%{_prefix}
 exec_prefix=${prefix}
@@ -58,29 +53,33 @@
 EOF

 %build
-%configure --demo=no \
-    --hash=yes \
-    --charset=yes \
-    --force-utf=yes \
-    --kind=shared \
-
+%configure \
+  --kind=shared \
+  --mode=relwithdebinfo \
+  --hash=yes \
+  --charset=yes \
+  --float=yes \
+  --force_utf8=yes
 %make_build

 %install
 %make_install
+rm %{buildroot}%{_bindir}/demo

-mkdir -p %{buildroot}%{_libdir}/pkgconfig
-install -pDm644 %{name}.pc %{buildroot}%{_libdir}/pkgconfig/%{name}.pc
+install -Dm644 %{name}.pc %{buildroot}%{_libdir}/pkgconfig/
+
+%check
+%make_build run

 %files
-%license LICENSE.md
-%doc README.md
-%{_libdir}/libtbox.so.%{sover}*
+%doc README.md README_zh.md CHANGELOG.md
+%license LICENSE.md NOTICE.md
+%{_libdir}/%{name}.so.1*

 %files devel
-%{_includedir}/tbox/
-%{_libdir}/libtbox.so
+%{_libdir}/%{name}.so
 %{_libdir}/pkgconfig/%{name}.pc
+%{_includedir}/tbox/

 %changelog
 %autochangelog


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2249637

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249637%23c16
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux