Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cpipe - Counting pipe https://bugzilla.redhat.com/show_bug.cgi?id=427662 ------- Additional Comments From terjeros@xxxxxxxxxxxx 2008-01-14 15:28 EST ------- > Why you are using group Development/Tools ? It has nothing with development. > I think better group is defined upstream: Applications/Archiving, or may be > Applications/System. I don't know, Applications/Archiving was too strange andnarrow, Applications/System is possible. > %{__chmod} 0644 %{buildroot}%{_mandir}/man1/%{name}* > - it is not necessary, just add %attr(0644, root, root) before this file in > %files section. I like it this way, as it clearly signal that something is wrong. > Some developers does not like macros like "%{__rm}" or "%{__make}". I prefer to use macros in my packages. > Why cpipe is better like program "pv" already included in Fedora? > Do we need both of them? I see no harm in including cpipe. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review