https://bugzilla.redhat.com/show_bug.cgi?id=2078535 --- Comment #6 from Jonny Heggheim <hegjon@xxxxxxxxx> --- (In reply to Felix Wang from comment #5) > There are some minor issues in reviewing the package. > > 1. > > License: BSD > > Use SPDX license format. > > 2. > > %forgesetup > > %patch -P 0 -p 1 > > It could be replaced by `%forgeautosetup -p1`. > > 3. > > Release: 1%{?dist} > > It would be better to use %autorelease macro. > Thanks for doing the review, I have fixed these issues and uploaded new version. The URLs are the same. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2078535 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202078535%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
