Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dropbear - SSH2 server and client https://bugzilla.redhat.com/show_bug.cgi?id=427738 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From tcallawa@xxxxxxxxxx 2008-01-14 14:26 EST ------- Good: - rpmlint checks return: dropbear.src:81: W: macro-in-%changelog setup dropbear.src: W: mixed-use-of-spaces-and-tabs (spaces: line 82, tab: line 1) Both of these are trivial, but you really shouldn't use macros in %changelog, because rpm will try to evaluate them. Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (97f31bbe1d36f156ec895de97ecc1d400da5f0e5) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. Go ahead and request sponsorship, as described here: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review