https://bugzilla.redhat.com/show_bug.cgi?id=2249395 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Spec URL: https://pagure.io/86box/blob/master/f/86box.spec This leads to a syntax-highlighted HTML rendition of the spec. Please use "raw file" links. > License: GPLv2+ Old Callaway-style tag. The SPDX equivalent of this is "GPL-2.0-or-later". https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > %ifarch i386 x86_64 It'd probably be safer to use the "%{ix86}" macro here instead of just "i386". > %ifarch arm aarch64 Same here - use the "%{arm32}" macro to check for 32-bit ARM architectures. > mkdir -p $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/${i}x${i}/apps > ... > desktop-file-install --dir=%{buildroot}%{_datadir}/applications src/unix/assets/net.86box.86Box.desktop Mixed use of %{buildroot} and $RPM_BUILD_ROOT. Please pick one and stick with it. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2249395 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249395%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
