https://bugzilla.redhat.com/show_bug.cgi?id=2249606 --- Comment #3 from Peter Robinson <pbrobinson@xxxxxxxxx> --- (In reply to Felix Wang from comment #1) > I take this. The review of the retired package mostly looks fine. > > 1. > > License: GPLv2+ > > It needs to be SPDX license format. Completely missed that. Updated > The following two issues are suggested, it is up to you. > 2. > > Release: 1%{?dist} > > Use %autorelease macro. > > 3. > > %setup -q > > Use %autosetup macro. All fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2249606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249606%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
