[Bug 2249479] Review Request: python-rpmautospec-core - Minimum functionality for rpmautospec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2249479

Nils Philippsen <nphilipp@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nphilipp@xxxxxxxxxx



--- Comment #3 from Nils Philippsen <nphilipp@xxxxxxxxxx> ---
Spec URL:
https://nphilipp.fedorapeople.org/review/python-rpmautospec-core/2/python-rpmautospec-core.spec
SRPM URL:
https://nphilipp.fedorapeople.org/review/python-rpmautospec-core/2/python-rpmautospec-core-0.1.0-1.fc40.src.rpm

This fixes one of the two issues…

(In reply to Stephen Gallagher from comment #1)
> Two minor issues, see below:
…
> Issues:
> =======
> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file LICENSE is not marked as %license
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/LicensingGuidelines/#_license_text

This is because poetry doesn’t let us mark license files as such in the Python
package metadata, therefore the %pyproject_save_files won’t tag them with
%license. I’ve added a workaround.

> - Specfile is 0600 permissions, should be 0644.

This is a bug in rpmautospec (ironically) which is fixed in the repo but not
yet released (which I wanted to do for a while but always got distracted). The
unprocessed spec file has 0644.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2249479

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249479%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux