https://bugzilla.redhat.com/show_bug.cgi?id=2248784 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #3) > Taking this review Thanks! > General comments: > > - Package was generated with rust2rpm > - Some tests were skipped because of missing files --> OK > - Some dependencies were manually updated to the latest version --> OK but > maybe consider patching this upstream ring was already updated to v0.17 upstream: https://github.com/EmbarkStudios/cargo-deny/commit/6a26873 for gix 0.54 -> 0.55, I will submit a PR. > Questions: > > - Why is the SPDX license list data updated? Looking at upstream, it seems > the file is 4 years old. Should this be reported? Probably ... there have been lots of licenses added to SPDX since Fedora started using it, so four year old data is very old. > - What is the license under which the license list is published? I could not > find any information about that (looked in > https://github.com/spdx/license-list-data and > https://github.com/spdx/license-list-XML). I could not find more information about this either. I assumed it was fine ... but I will ask on the legal mailing list. > Problems: > > - False requires on `/usr/bin/bash`, excluding `scripts` should probably fix > this Good catch, I will do that. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2248784 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248784%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
