https://bugzilla.redhat.com/show_bug.cgi?id=2249268 --- Comment #4 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #3) Thank yu for the review! > a) Can the url be: > %{url}/archive/v%{version}/isa-l-%{version}.tar.gz > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags Done. > b) The line > %ldconfig_scriptlets > can be removed, not longer needed Still needed for EPEL 7 > c) The first part of the soname should be included instead of > %{_libdir}/libisal.so.* > use > %{_libdir}/libisal.so.2.* Done (but without the . before *) > d) Can the s390x patch be upstreamed? The patch is a backport from upstream. I added a comment with a link. > e) Can -fpic or -pic be added to the flags? > isa-l.aarch64: E: shlib-with-non-pic-code /usr/lib64/libisal.so.2.0.30 The build alredy uses -fPIC. This is due to assembler code. Fixed upsream. Added one more backport patch. Spec and srpm updated at the same locations. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249268 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249268%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
