Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monotools - access to monodoc without using monodevelop https://bugzilla.redhat.com/show_bug.cgi?id=210776 david@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jpmahowald@xxxxxxxxx |david@xxxxxxxxxxxxx ------- Additional Comments From david@xxxxxxxxxxxxx 2008-01-14 13:21 EST ------- GOOD: Builds in mock (fedora-development-x86_64) Spec is in readable US English, and sexy sed magic Cleans up after itself Owns all the good stuff BAD: mono-tools.src: W: strange-permission mono-tools.patch 0600 File permissions should be %defattr(-,root,root,-) Should excludearch ppc64 on account of #241850 - remember to add a note please (I suspect I forgot this in the previous mono reviews - please apply liberally to mono specs) mergh?: I'm still not liking that whole defining the libdir thing, it seems like a build system bug which we are hiding but in this case it's even uglier than before. Please consider removing the define and just invoking %{_libdir} as an argument to configure. You might also want to expand the description a bit so it makes more sense for users such as which tools this package provides. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review