https://bugzilla.redhat.com/show_bug.cgi?id=2244318 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx --- Comment #6 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- I was testing the tool and found this review request. I'm adding some comments. > BuildRequires: pytest Would be better: BuildRequires: python3dist(pytest) > %autosetup -n ssh-audit-%{version} It can be just %autosetup > # Remove bundled egg-info > rm -rf %{name}.egg-info No need as you're using pyproject-rpm-macros and takes care of it You can add the following in the %prep section, after %autosetup, to fix the "E: non-executable-script" error: #remove shebang sed -i -e '1{\@^#!/usr/bin/env python@d}' src/ssh_audit/ssh_audit.py In the %files section, add the following: %license LICENSE Also, I would replace Release and %changelog content for rpmautospec's %autorelease & %autochangelog -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244318 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244318%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
