https://bugzilla.redhat.com/show_bug.cgi?id=2244402 --- Comment #18 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Maxwell G from comment #17) > - [!] Package does not run builds outside of %build > > `ant ebcdic` is not a configure script. The `ebcdic` target's description > says "_build_ ebcdic package for Python." It calls `setup.py` and other > build tasks. Please move it to %build. It is in the context of `ebcdic` package. I removed the call to `setup.py` from `build.xml`. I cannot move `ant ebcdic` to %build without extensive modification to the entire environment. I'd also like to keep using `%pyproject_buildrequires` for dynamic requirements generation. I think I've already come a long way from the initial proposal of running `ant ebcdic` in %prep. Seeing that everything ant produces besides the codecs itself, is subsequently removed. I don't see any harm of running the script in either %prep or %conf. Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/reviews/fedora-rawhide-x86_64/06624382-python-ebcdic/python-ebcdic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/reviews/fedora-rawhide-x86_64/06624382-python-ebcdic/python-ebcdic-1.1.1-5.fc40.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244402 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244402%23c18 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
