Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Falcon - The Falcon Programming Language https://bugzilla.redhat.com/show_bug.cgi?id=428603 michel.sylvan@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |michel.sylvan@xxxxxxxxx Status|NEW |ASSIGNED Summary|Review Request: Falcon - The|Review Request: Falcon - The |Falcon Programming Language |Falcon Programming Language Flag| |fedora-review? ------- Additional Comments From michel.sylvan@xxxxxxxxx 2008-01-14 09:59 EST ------- Will do full review in a bit, but here's the result of running rpmlint on the package, as well as suggested changes. Falcon.src: E: invalid-spec-name falcon.spec -- should be Falcon.spec Falcon.src: E: non-utf8-spec-file /tmp/Falcon-0.8.7-1.src.rpm.31479/falcon.spec -- just re-save the spec file with UTF8 character encoding Falcon.src:31: W: hardcoded-prefix-tag %{prefix} Falcon.src:37: W: hardcoded-packager-tag Giancarlo Falcon.src:39: W: unversioned-explicit-provides %{name} -- Please remove these. Also, release number should be followed by %{?dist} so that when your package is built on the build server, it is tagged with the distribution name (.f8, .f9, etc) Falcon.src:40: W: hardcoded-path-in-buildroot-tag /tmp/%{name}-%{version} -- see this document: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 Falcon.src:64: W: setup-not-quiet -- add -q to %setup Falcon.src:65: W: rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT -- rm -rf should only be in %install and %clean Falcon.src:72: W: rpm-buildroot-usage %build ./build.sh -p $RPM_BUILD_ROOT/usr -f /usr -- use %{_prefix} instead of /usr . I guess $RPM_BUILD_ROOT can't be avoided here because of the way build.sh is written Falcon.src:118: E: hardcoded-library-path in /usr/lib -- in %files, use %{_bindir}, %{_includedir}, %{_datadir} and %{_libdir} Falcon.src: E: no-changelogname-tag -- add a %changelog section at bottom with entries in this format: * Mon Jan 14 2008 Giancarlo Niccolai <gc@xxxxxxxxxxxx> -- 0.8.7-1 - Initial Fedora package Falcon.src: W: invalid-license Falcon License -- Might have to clear this on the fedora-legal mailing list; it is not a pre-approved license. How different is it from the Apache 2.0 license? See http://fedoraproject.org/wiki/Packaging/LicensingGuidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review