https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #29 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you all. Package looks good to me. Full review below. ======================================================================= Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. [x]: Rpmlint is run on debuginfo package(s). [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: helix-23.10-1.fc40.x86_64.rpm helix-debuginfo-23.10-1.fc40.x86_64.rpm helix-debugsource-23.10-1.fc40.x86_64.rpm helix-23.10-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7haz8vh3')] checks: 31, packages: 4 helix.x86_64: E: zero-length /usr/lib64/helix/runtime/queries/bibtex/locals.scm helix.x86_64: E: zero-length /usr/lib64/helix/runtime/queries/bibtex/tags.scm These look harmless. helix.spec:83: W: unversioned-explicit-provides bundled(*) This is OK if there's no real version to assign. helix.src: W: strange-permission helix.spec 600 This is an artefact of a bug in rpmautospec. helix.x86_64: E: non-executable-script /usr/share/bash-completion/completions/hx 644 /usr/bin/env bash helix.x86_64: E: non-executable-script /usr/share/fish/vendor_completions.d/hx.fish 644 /usr/bin/env fish This is OK. helix.x86_64: W: no-manual-page-for-binary hx This is OK too. helix-debugsource.x86_64: E: files-duplicated-waste 978826 This is OK. Deduplicating these files is not really feasible. 4 packages and 0 specfiles checked; 5 errors, 208 warnings, 5 badness; has taken 15.5 s Rpmlint (debuginfo) ------------------- Checking: helix-debuginfo-23.10-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6cbfxkfg')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 5.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 helix.x86_64: E: zero-length /usr/lib64/helix/runtime/queries/bibtex/locals.scm helix.x86_64: E: zero-length /usr/lib64/helix/runtime/queries/bibtex/tags.scm These are OK. These files are empty on purpose, I assume. helix.x86_64: W: unused-direct-shlib-dependency /usr/lib64/helix/runtime/grammars/*.so /lib64/libm.so.6 helix.x86_64: W: unused-direct-shlib-dependency /usr/lib64/helix/runtime/grammars/*.so /lib64/libgcc_s.so.1 This looks like an artifact of these files being compiled with the "cc" crate. Not sure if it's possible to skip linking with libm and libgcc_s. helix.x86_64: E: non-executable-script /usr/share/bash-completion/completions/hx 644 /usr/bin/env bash helix.x86_64: E: non-executable-script /usr/share/fish/vendor_completions.d/hx.fish 644 /usr/bin/env fish These are OK. helix.x86_64: W: no-manual-page-for-binary hx OK as well. helix-debugsource.x86_64: E: files-duplicated-waste 978826 Not really feasible to deduplicate these files, as far as I can tell. 3 packages and 0 specfiles checked; 5 errors, 510 warnings, 5 badness; has taken 35.9 s Unversioned so-files -------------------- helix: /usr/lib64/helix/runtime/grammars/*.so These are plugins, they are supposed to be unversioned. Source checksums ---------------- https://raw.githubusercontent.com/blinxen/tree-sitter-smithy/main/LICENSE#/LICENSE-tree-sitter-smithy : CHECKSUM(SHA256) this package : c3f5bd7f82227a941b6d619d0d3f637bf94cbe0e13e9fdd5e060995c63f3a760 CHECKSUM(SHA256) upstream package : c3f5bd7f82227a941b6d619d0d3f637bf94cbe0e13e9fdd5e060995c63f3a760 https://raw.githubusercontent.com/blinxen/tree-sitter-vhs/main/LICENSE#/LICENSE-tree-sitter-vhs : CHECKSUM(SHA256) this package : 3417ae865a9c4b305e83425268a4a06ee1f389c7f4738ba0d72ddba7e9bf8f50 CHECKSUM(SHA256) upstream package : 3417ae865a9c4b305e83425268a4a06ee1f389c7f4738ba0d72ddba7e9bf8f50 https://raw.githubusercontent.com/blinxen/tree-sitter-pod/main/LICENSE#/LICENSE-tree-sitter-pod : CHECKSUM(SHA256) this package : b759fd95c70b136ab34d4aba06c580c8048bd9b5e2991fe6914e461662ef0218 CHECKSUM(SHA256) upstream package : b759fd95c70b136ab34d4aba06c580c8048bd9b5e2991fe6914e461662ef0218 https://raw.githubusercontent.com/blinxen/tree-sitter-eex/main/LICENSE#/LICENSE-tree-sitter-eex : CHECKSUM(SHA256) this package : 4bfe090c69931f7dbb26546f6bac9117d881bede4600c8648de34ed1b4725308 CHECKSUM(SHA256) upstream package : 4bfe090c69931f7dbb26546f6bac9117d881bede4600c8648de34ed1b4725308 https://raw.githubusercontent.com/Maskhjarna/tree-sitter-purescript/main/LICENSE#/LICENSE-tree-sitter-purescript : CHECKSUM(SHA256) this package : e6708d41a3bb4757528ba7903f6cbef66bd8a453d341ac77500f02db1ad42ef8 CHECKSUM(SHA256) upstream package : e6708d41a3bb4757528ba7903f6cbef66bd8a453d341ac77500f02db1ad42ef8 https://raw.githubusercontent.com/kylegoetz/tree-sitter-unison/master/LICENSE#/LICENSE-tree-sitter-unison : CHECKSUM(SHA256) this package : cee7dcc846a5cc89b160ce3ddd23ec6fb606f1a90b7e1b4c815b28940a117968 CHECKSUM(SHA256) upstream package : cee7dcc846a5cc89b160ce3ddd23ec6fb606f1a90b7e1b4c815b28940a117968 https://raw.githubusercontent.com/FallenAngel97/tree-sitter-rego/master/LICENSE#/LICENSE-tree-sitter-rego : CHECKSUM(SHA256) this package : 7eeb3c3b1789d235ea1866fe1e0790233a9679b7ef8415ce93ab454775ebcb4f CHECKSUM(SHA256) upstream package : 7eeb3c3b1789d235ea1866fe1e0790233a9679b7ef8415ce93ab454775ebcb4f https://raw.githubusercontent.com/AlexanderBrevig/tree-sitter-forth/main/LICENSE#/LICENSE-tree-sitter-forth : CHECKSUM(SHA256) this package : 616f6dd042987a369f7962ee7a1f4fd9ab136c89f0677c6b2f4f1a5a34a30a2b CHECKSUM(SHA256) upstream package : 616f6dd042987a369f7962ee7a1f4fd9ab136c89f0677c6b2f4f1a5a34a30a2b https://raw.githubusercontent.com/Jummit/tree-sitter-uxntal/master/LICENSE#/LICENSE-tree-sitter-uxntal : CHECKSUM(SHA256) this package : dbda82e6febb4184d74ed80d1c85f658ec3f431b3cc40e7908ac92e09a485a0d CHECKSUM(SHA256) upstream package : dbda82e6febb4184d74ed80d1c85f658ec3f431b3cc40e7908ac92e09a485a0d https://raw.githubusercontent.com/virchau13/tree-sitter-astro/master/LICENSE#/LICENSE-tree-sitter-astro : CHECKSUM(SHA256) this package : 9ec95a90150fa19e2cee78faf49138fc480f6f7a2354006a0ab150c44239447e CHECKSUM(SHA256) upstream package : 9ec95a90150fa19e2cee78faf49138fc480f6f7a2354006a0ab150c44239447e https://raw.githubusercontent.com/tree-sitter-perl/tree-sitter-perl/master/LICENSE#/LICENSE-tree-sitter-perl : CHECKSUM(SHA256) this package : 19e2e0f2079ea1ce1576eb4ecc0575b33fe45b2b8e71f4aa589d6bedd1da4e0a CHECKSUM(SHA256) upstream package : 19e2e0f2079ea1ce1576eb4ecc0575b33fe45b2b8e71f4aa589d6bedd1da4e0a https://raw.githubusercontent.com/Philipp-M/tree-sitter-ungrammar/main/LICENSE#/LICENSE-tree-sitter-ungrammar : CHECKSUM(SHA256) this package : 6fe9d0b41450b02419e92daab3cef9413300a0cd3d9fc650d474804d646cdcec CHECKSUM(SHA256) upstream package : 6fe9d0b41450b02419e92daab3cef9413300a0cd3d9fc650d474804d646cdcec https://raw.githubusercontent.com/polarmutex/tree-sitter-beancount/master/LICENSE#/LICENSE-tree-sitter-beancount : CHECKSUM(SHA256) this package : 8976806a7d187d8e152d49146fae44d8a98bb15be05099e63843756c116efcf0 CHECKSUM(SHA256) upstream package : 8976806a7d187d8e152d49146fae44d8a98bb15be05099e63843756c116efcf0 https://raw.githubusercontent.com/stsewd/tree-sitter-comment/master/LICENSE#/LICENSE-tree-sitter-comment : CHECKSUM(SHA256) this package : 711e47fad3c2f298c4fdd21cc54b147ab1a73648b530c9940a0327e2cc905248 CHECKSUM(SHA256) upstream package : 711e47fad3c2f298c4fdd21cc54b147ab1a73648b530c9940a0327e2cc905248 https://raw.githubusercontent.com/benwilliamgraham/tree-sitter-llvm/main/LICENSE#/LICENSE-tree-sitter-llvm : CHECKSUM(SHA256) this package : a292ff39c53d0d2af3a0804ec291737508f1c888efb148f8f2bd3030e7cfdc48 CHECKSUM(SHA256) upstream package : a292ff39c53d0d2af3a0804ec291737508f1c888efb148f8f2bd3030e7cfdc48 https://raw.githubusercontent.com/DerekStride/tree-sitter-sql/main/LICENSE#/LICENSE-tree-sitter-sql : CHECKSUM(SHA256) this package : 3b3e4e4252d5d7d1c18e1257005f23242bf0580ad619204fd093c99b8c56748d CHECKSUM(SHA256) upstream package : 3b3e4e4252d5d7d1c18e1257005f23242bf0580ad619204fd093c99b8c56748d https://raw.githubusercontent.com/helix-editor/helix/master/runtime/themes/licenses/sonokai.LICENSE : CHECKSUM(SHA256) this package : 1578c1d9fe713f0ee479ff822b82baddbd2dfecf1f247a3f72bbdae5e0162e7e CHECKSUM(SHA256) upstream package : 1578c1d9fe713f0ee479ff822b82baddbd2dfecf1f247a3f72bbdae5e0162e7e https://raw.githubusercontent.com/helix-editor/helix/master/runtime/themes/licenses/serika-syntax.LICENSE : CHECKSUM(SHA256) this package : c0a2e97702d1e06a613e53fd7286b9fd2a260d93a29368d98e0a44bbd4f028eb CHECKSUM(SHA256) upstream package : c0a2e97702d1e06a613e53fd7286b9fd2a260d93a29368d98e0a44bbd4f028eb https://raw.githubusercontent.com/helix-editor/helix/master/runtime/themes/licenses/everforest.LICENSE : CHECKSUM(SHA256) this package : 6504b9e62794cb58b61c90ea5fe598274086119f2126b8d8245708b2bfcc0e36 CHECKSUM(SHA256) upstream package : 6504b9e62794cb58b61c90ea5fe598274086119f2126b8d8245708b2bfcc0e36 https://github.com/helix-editor/helix/releases/download/23.10/helix-23.10-source.tar.xz : CHECKSUM(SHA256) this package : 4e7bcac200b1a15bc9f196bdfd161e4e448dc670359349ae14c18ccc512153e8 CHECKSUM(SHA256) upstream package : 4e7bcac200b1a15bc9f196bdfd161e4e448dc670359349ae14c18ccc512153e8 Requires -------- helix (rpmlib, GLIBC filtered): gcc-c++ git-core ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) helix-debuginfo (rpmlib, GLIBC filtered): helix-debugsource (rpmlib, GLIBC filtered): Provides -------- helix: application() application(Helix.desktop) bundled(tree-sitter-astro) bundled(tree-sitter-awk) bundled(tree-sitter-bash) bundled(tree-sitter-bass) bundled(tree-sitter-beancount) bundled(tree-sitter-bibtex) bundled(tree-sitter-bicep) bundled(tree-sitter-blueprint) bundled(tree-sitter-c) bundled(tree-sitter-c-sharp) bundled(tree-sitter-capnp) bundled(tree-sitter-cassette) bundled(tree-sitter-clojure) bundled(tree-sitter-cmake) bundled(tree-sitter-comment) bundled(tree-sitter-cpon) bundled(tree-sitter-cpp) bundled(tree-sitter-css) bundled(tree-sitter-cue) bundled(tree-sitter-d) bundled(tree-sitter-dart) bundled(tree-sitter-devicetree) bundled(tree-sitter-dhall) bundled(tree-sitter-diff) bundled(tree-sitter-dockerfile) bundled(tree-sitter-dot) bundled(tree-sitter-dtd) bundled(tree-sitter-edoc) bundled(tree-sitter-eex) bundled(tree-sitter-elixir) bundled(tree-sitter-elm) bundled(tree-sitter-elvish) bundled(tree-sitter-embedded-template) bundled(tree-sitter-erlang) bundled(tree-sitter-esdl) bundled(tree-sitter-fish) bundled(tree-sitter-forth) bundled(tree-sitter-fortran) bundled(tree-sitter-fsharp) bundled(tree-sitter-gas) bundled(tree-sitter-gdscript) bundled(tree-sitter-gemini) bundled(tree-sitter-git-config) bundled(tree-sitter-gitattributes) bundled(tree-sitter-gitcommit) bundled(tree-sitter-gitignore) bundled(tree-sitter-gleam) bundled(tree-sitter-glsl) bundled(tree-sitter-go) bundled(tree-sitter-go-mod) bundled(tree-sitter-go-template) bundled(tree-sitter-go-work) bundled(tree-sitter-godot-resource) bundled(tree-sitter-graphql) bundled(tree-sitter-hare) bundled(tree-sitter-haskell) bundled(tree-sitter-haskell-persistent) bundled(tree-sitter-hcl) bundled(tree-sitter-heex) bundled(tree-sitter-hosts) bundled(tree-sitter-html) bundled(tree-sitter-hurl) bundled(tree-sitter-iex) bundled(tree-sitter-ini) bundled(tree-sitter-java) bundled(tree-sitter-javascript) bundled(tree-sitter-jinja2) bundled(tree-sitter-jsdoc) bundled(tree-sitter-json) bundled(tree-sitter-json5) bundled(tree-sitter-jsonnet) bundled(tree-sitter-julia) bundled(tree-sitter-just) bundled(tree-sitter-kdl) bundled(tree-sitter-kotlin) bundled(tree-sitter-latex) bundled(tree-sitter-lean) bundled(tree-sitter-ledger) bundled(tree-sitter-llvm) bundled(tree-sitter-llvm-mir) bundled(tree-sitter-lua) bundled(tree-sitter-make) bundled(tree-sitter-markdoc) bundled(tree-sitter-markdown) bundled(tree-sitter-matlab) bundled(tree-sitter-mermaid) bundled(tree-sitter-meson) bundled(tree-sitter-nasm) bundled(tree-sitter-nickel) bundled(tree-sitter-nim) bundled(tree-sitter-nix) bundled(tree-sitter-nu) bundled(tree-sitter-ocaml) bundled(tree-sitter-odin) bundled(tree-sitter-opencl) bundled(tree-sitter-openscad) bundled(tree-sitter-org) bundled(tree-sitter-pascal) bundled(tree-sitter-passwd) bundled(tree-sitter-pem) bundled(tree-sitter-perl) bundled(tree-sitter-php) bundled(tree-sitter-po) bundled(tree-sitter-pod) bundled(tree-sitter-ponylang) bundled(tree-sitter-prisma) bundled(tree-sitter-protobuf) bundled(tree-sitter-prql) bundled(tree-sitter-purescript) bundled(tree-sitter-python) bundled(tree-sitter-qmljs) bundled(tree-sitter-r) bundled(tree-sitter-rebase) bundled(tree-sitter-regex) bundled(tree-sitter-rego) bundled(tree-sitter-rescript) bundled(tree-sitter-robot) bundled(tree-sitter-rst) bundled(tree-sitter-ruby) bundled(tree-sitter-rust) bundled(tree-sitter-scala) bundled(tree-sitter-scheme) bundled(tree-sitter-scss) bundled(tree-sitter-slint) bundled(tree-sitter-smithy) bundled(tree-sitter-sml) bundled(tree-sitter-solidity) bundled(tree-sitter-sql) bundled(tree-sitter-ssh-client-config) bundled(tree-sitter-strace) bundled(tree-sitter-svelte) bundled(tree-sitter-sway) bundled(tree-sitter-swift) bundled(tree-sitter-t32) bundled(tree-sitter-tablegen) bundled(tree-sitter-task) bundled(tree-sitter-templ) bundled(tree-sitter-todotxt) bundled(tree-sitter-toml) bundled(tree-sitter-tsq) bundled(tree-sitter-twig) bundled(tree-sitter-typescript) bundled(tree-sitter-ungrammar) bundled(tree-sitter-unison) bundled(tree-sitter-uxntal) bundled(tree-sitter-v) bundled(tree-sitter-vala) bundled(tree-sitter-verilog) bundled(tree-sitter-vhdl) bundled(tree-sitter-vue) bundled(tree-sitter-wasm) bundled(tree-sitter-wgsl) bundled(tree-sitter-wit) bundled(tree-sitter-wren) bundled(tree-sitter-xit) bundled(tree-sitter-xml) bundled(tree-sitter-yaml) bundled(tree-sitter-yuck) bundled(tree-sitter-zig) helix helix(x86-64) mimehandler(application/x-shellscript) mimehandler(text/english) mimehandler(text/plain) mimehandler(text/x-c) mimehandler(text/x-c++) mimehandler(text/x-c++hdr) mimehandler(text/x-c++src) mimehandler(text/x-chdr) mimehandler(text/x-csrc) mimehandler(text/x-java) mimehandler(text/x-makefile) mimehandler(text/x-moc) mimehandler(text/x-pascal) mimehandler(text/x-tcl) mimehandler(text/x-tex) helix-debuginfo: debuginfo(build-id) helix-debuginfo helix-debuginfo(x86-64) helix-debugsource: helix-debugsource helix-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/deca/Downloads/2246561-helix/srpm/helix.spec 2023-11-08 13:33:03.997028791 +0100 +++ /home/deca/Downloads/2246561-helix/srpm-unpacked/helix.spec 2023-11-07 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %bcond_without check @@ -327,3 +337,4 @@ %changelog -%autochangelog +* Tue Nov 07 2023 John Doe <packager@xxxxxxxxxxx> - 23.10-1 +- Uncommitted changes This is an artifact of using "fedpkg srpm" instead of "rpmbuild -bs" for building the SRPM file. Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2246561 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Python, Haskell, fonts, Perl, Java, Ocaml, SugarActivity, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c29 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
