https://bugzilla.redhat.com/show_bug.cgi?id=2247350 --- Comment #18 from Davide Cavalca <davide@xxxxxxxxxxxx> --- - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-2.0-only and (Apache-2.0 and (Apache-2.0 or MIT) and (Apache-2.0 with LLVM-exception or Apache-2.0 or MIT) and MIT and MPL-2.0 and (Unlicense or MIT))'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 I think SPDX wants AND and OR to be capitalized [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "GNU General Public License v2.0 or later and/or PostgreSQL License", "GNU Lesser General Public License, Version 2.1", "BSD 3-Clause License", "GNU General Public License v2.0 or later", "BSD 2-Clause License and/or GNU General Public License, Version 2", "*No copyright* GNU Lesser General Public License, Version 2.1", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License", "Public domain", "*No copyright* The Unlicense", "MIT License", "*No copyright* MIT License", "*No copyright* Apache License 2.0", "Apache License 2.0 and/or MIT License", "*No copyright* Mozilla Public License 2.0", "*No copyright* Apache License (v2.0) or MIT license", "Apache License 2.0 and/or BSD 3-Clause License", "Apache License 2.0", "Unicode License Agreement - Data Files and Software (2016)", "Apache License (v2.0) or MIT license", "Apache License (v2.0) or MIT license and/or MIT License", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License". 6315 files have unknown license. Detailed output of licensecheck in /tmp/2247350-bcachefs-tools/licensecheck.txt You'll want to recheck the license breakdown, there's definitely stuff you're not currently listing (e.g. some BSD-3-Clause under libbcachefs/siphash.{c,h}). You also need to add bundled Provides for all the vendored stuff (and ensure that's factored into the license breakdown as well). And ideally we should engage with upstream to get rid of the vendored stuff altogether in the long run, as this won't be terribly maintainable as-is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2247350 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247350%23c18 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
