https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Seth Maurice-Brant <fedoraproject.kwudj@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedoraproject.kwudj@passinb | |ox.com --- Comment #24 from Seth Maurice-Brant <fedoraproject.kwudj@xxxxxxxxxxxxx> --- This is quite a big package, and for the most part it does look good to me, building locally works fine. However there are a couple of things that may be worth considering. - There is no man page for hx, which is what most users will be running, maybe add an alias to the helix manpage? - rpmlint goes pretty crazy, but most of it seems like it can be ignored. - helix.spec has permission 600, this seems a bit odd, is there a specific reason for that? - fedora-review believes there is an uncommitted change,might be worth checking that out. - Other minor issues I found have been discussed already === Other than couple of small problems, I believe this is in good working order. I can't wait to replace my copr version of helix with an official one. Good luck and congratulations on getting this far! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c24 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
