https://bugzilla.redhat.com/show_bug.cgi?id=2244974 --- Comment #8 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Maxwell G from comment #6) > %pyproject_save_files -l is _not_ yet available. The PR to add it is still > under review. There is no requirement to remove the %license from %files if > %pyproject_save_files handles it. I didn't say it was a requirement. I said you 'may drop ...' and the item was still marked [x]. Hopefully, the `-l` flag becomes available soon. I, personally, don't like having to check manually if a license file is already included. Up until recently, I used the same approach of including the license file explicitly regardless of `%pyproject_save_files`. > > Maybe include CONTRIBUTING.rst as %doc > > That file is not user facing documentation and doesn't make sense to include > in the RPM package. Aren't developers users as well? Besides, you do include a similar file with much less value in `bindep`. But, again, not a requirement. > I'll take a look at the licensing issue and update the package. Thanks for > all the reviews! Thanks. The licensing is clear now and the package has been updated to the latest release. One remaining issue: [!]: Rpmlint is run on all installed packages. => The shebangs are still present and cause rpmlint to emit errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244974 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244974%23c8 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
