[Bug 2244406] Review Request: python-RTFDE - A library for extracting HTML content from RTF encapsulated HTML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2244406

Maxwell G <maxwell@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |maxwell@xxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |maxwell@xxxxxxx
             Status|NEW                         |ASSIGNED



--- Comment #1 from Maxwell G <maxwell@xxxxxxx> ---
Maxwell's Python Package Review Template
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [!] The License tag reflects the package contents and uses the correct
identifiers.
- [!] The license text is included and marked with %license.
NOTE: Files in the project include GPLv3+ headers, but the metadata and LICENSE
claims LGPLv3. Can you clarify this with upstream?

- [x] The package builds successfully in mock.
- [x] The package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] The latest version is packaged or packaging an earlier version is
justified.

- [!] The packager considers avoiding confusing `%foo_name` macros. (Not a
blocker)

- [!] Libraries: The package name has a `python3-` prefix and uses the
canonical project name
NOTE: The SRPM should be named python-rtfde and the binary package should be
named python3-rftde.

- [x] The pyproject macros are used.
- [x] The package complies with the Python and general Packaging Guidelines.


Other Notes
===========

- You should add `%global distprefix %{nil}` so the forge macros don't add
.20231015git66780b8 to the disttag. This is not a git snapshot; upstream just
doesn't tag releases.
- It'd be better to use the `%{...}` syntax when referencing the `%forge*`
macros in the specfile.
- The doc subpackage should not require the python3-... subpackage.

Thanks!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244406

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244406%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux