https://bugzilla.redhat.com/show_bug.cgi?id=2245348 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? CC| |zbyszek@xxxxxxxxx --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Everything looks pretty nice and clean… Some questions and suggestions below. It's nicer when %description is wrapped to <=80 columns (currently it's rather narrower). > %package static > Requires: %{name}-devel%{?_isa} = %{version}-%{release} I don't think the Requires is necessary. Nothing in the static library uses files from -devel. > %description static The description should end in a dot. > %{_libdir}/janet/janet.c > %{_libdir}/libjanet.so.1.* > %{_libdir}/libjanet.a So the library part is delivered as a shared libary, a static library, and an embeddable source file… Is anything except a shared library really needed? How do you plan to use this? If it's as a dependency for other fedora packages, then I think the effort should go into everybody using the shared library. $ ls -l /usr/bin/janet /usr/lib64/libjanet.so.1.32.1 -rwxr-xr-x 1 root root 788360 Oct 20 02:00 /usr/bin/janet -rwxr-xr-x 1 root root 811744 Oct 20 02:00 /usr/lib64/libjanet.so.1.32.1 Please link /usr/bin/janet to the shared library. This will shave off ~50% percent of the package size. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2245348 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245348%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
