https://bugzilla.redhat.com/show_bug.cgi?id=890772 --- Comment #31 from Felix Kaechele <felix@xxxxxxxxxxx> --- Looking good except for one minor thing (the directory ownership of /usr/share/doc/tvlsim). When that's fixed I'm good to approve. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Notes: ====== - BuildRequires: cppzmq-devel could be expressed as BuildRequires: pkgconfig(cppzmq) - Source contains bundled libraries, but those don't end up in the built package. This is acceptable. - fedora-review complains "Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tvlsim-devel" but that is not actually the case. - "tvlsim-doc.noarch: W: files-duplicate" warnings are an artifact of the doxygen process. Not a concern. - I didn't test functionality of the package as there is some more setup involved. The "tvlsim_simulate" binary crashes and coredumps when started without proper configuration. Just thought I'd mention it. Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file copyright.html is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text -> This is a doxygen generated file, the license text is already properly marked as %license - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: tvlsim-1.01.6-1.spec should be tvlsim.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming -> False alarm - Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/tvlsim -> The doc subpackage should use %doc %{_docdir}/%{name} instead of %doc %{_docdir}/%{name}/html ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Library General Public License, Version 2.0", "FSF All Permissive License", "GNU Lesser General Public License v2.1 or later", "Boost Software License 1.0", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "MIT License", "JSON License and/or MIT License", "zlib License", "GNU General Public License, Version 2", "*No copyright* MIT License". 2288 files have unknown license. Detailed output of licensecheck in /home/felix/PackageReview/tvlsim/890772-tvlsim-1.01.6-1/licensecheck.txt -> License of files ending up in the package are accurately represented [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/tvlsim [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9309 bytes in 4 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tvlsim- devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tvlsim-1.01.6-1.fc40.x86_64.rpm tvlsim-devel-1.01.6-1.fc40.x86_64.rpm tvlsim-doc-1.01.6-1.fc40.noarch.rpm tvlsim-debuginfo-1.01.6-1.fc40.x86_64.rpm tvlsim-debugsource-1.01.6-1.fc40.x86_64.rpm tvlsim-1.01.6-1.fc40.src.rpm ============================================================================================================= rpmlint session starts ============================================================================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuzh73jow')] checks: 31, packages: 6 tvlsim-doc.noarch: W: files-duplicate /usr/share/doc/tvlsim/html/search/functions_6.js /usr/share/doc/tvlsim/html/search/all_12.js tvlsim-doc.noarch: W: files-duplicate /usr/share/doc/tvlsim/html/search/functions_10.js /usr/share/doc/tvlsim/html/search/all_21.js tvlsim-doc.noarch: W: files-duplicate /usr/share/doc/tvlsim/html/search/variables_0.js /usr/share/doc/tvlsim/html/search/all_8.js ============================================================================== 6 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 1.7 s ============================================================================== Rpmlint (debuginfo) ------------------- Checking: tvlsim-debuginfo-1.01.6-1.fc40.x86_64.rpm ============================================================================================================= rpmlint session starts ============================================================================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp94mmkgrm')] checks: 31, packages: 1 ============================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s ============================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 tvlsim-doc.noarch: W: files-duplicate /usr/share/doc/tvlsim/html/search/functions_6.js /usr/share/doc/tvlsim/html/search/all_12.js tvlsim-doc.noarch: W: files-duplicate /usr/share/doc/tvlsim/html/search/functions_10.js /usr/share/doc/tvlsim/html/search/all_21.js tvlsim-doc.noarch: W: files-duplicate /usr/share/doc/tvlsim/html/search/variables_0.js /usr/share/doc/tvlsim/html/search/all_8.js 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 1.6 s Source checksums ---------------- https://github.com/airsim/tvlsim/archive/refs/tags/v1.01.6.tar.gz#/tvlsim-1.01.6.tar.gz : CHECKSUM(SHA256) this package : 298d629b07ce5f1d9a16745bc37c4eddbdb44ab2e9b314288498931657002014 CHECKSUM(SHA256) upstream package : 298d629b07ce5f1d9a16745bc37c4eddbdb44ab2e9b314288498931657002014 Requires -------- tvlsim (rpmlib, GLIBC filtered): libboost_program_options.so.1.81.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libreadline.so.8()(64bit) libsevmgr.so.1.00()(64bit) libsimcrs.so.1.01()(64bit) libsoci_core.so.4.0()(64bit) libstdair.so.1.00()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtrademgen.so.1.00()(64bit) libtravelccm.so.1.00()(64bit) libtvlsim.so.1.01()(64bit) libzmq.so.5()(64bit) rtld(GNU_HASH) tvlsim-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config /usr/bin/sh libtvlsim.so.1.01()(64bit) pkgconfig tvlsim(x86-64) tvlsim-doc (rpmlib, GLIBC filtered): tvlsim-debuginfo (rpmlib, GLIBC filtered): tvlsim-debugsource (rpmlib, GLIBC filtered): Provides -------- tvlsim: libtvlsim.so.1.01()(64bit) tvlsim tvlsim(x86-64) tvlsim-devel: pkgconfig(tvlsim) tvlsim-devel tvlsim-devel(x86-64) tvlsim-doc: tvlsim-doc tvlsim-debuginfo: debuginfo(build-id) libtvlsim.so.1.01.6-1.01.6-1.fc40.x86_64.debug()(64bit) tvlsim-debuginfo tvlsim-debuginfo(x86-64) tvlsim-debugsource: tvlsim-debugsource tvlsim-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 890772 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Perl, Java, Python, Haskell, SugarActivity, PHP, fonts, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=890772 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20890772%23c31 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
