Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: minicom https://bugzilla.redhat.com/show_bug.cgi?id=226144 tyler.l.owen@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tyler.l.owen@xxxxxxxxx 2008-01-13 21:28 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 13933c8777839f00e3730df23599dc93 minicom-2.2.tar.gz 13933c8777839f00e3730df23599dc93 minicom-2.2.tar.gz1 OK - Package needs ExcludeArch OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. SRPM silent. See note 1. Not silent, but OK. Can be fixed with iconv OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should package latest version Notes: 1. Rpmlint output RPM: minicom.i386: W: file-not-utf8 /usr/share/doc/minicom-2.2/ChangeLog.old minicom.i386: W: file-not-utf8 /usr/share/doc/minicom-2.2/AUTHORS minicom.i386: W: file-not-utf8 /usr/share/doc/minicom-2.2/pl-translation.txt minicom.i386: W: file-not-utf8 /usr/share/doc/minicom-2.2/suomeksi minicom.i386: W: file-not-utf8 /usr/share/doc/minicom-2.2/portugues-brasil APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review