[Bug 2245445] Review Request: rust-logos-codegen - Implementation details for logos-codegen and logos-derive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2245445



--- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> Source1:		%{crate_instdir}/LICENSE-APACHE
> Source2:		%{crate_instdir}/LICENSE-MIT

How is this supposed to work? Source and Patch lines are about telling RPM
where to find files *before* building the package.
These are absolute paths, and they don't exist.

You will need to replace these two lines with something like this, to tell RPM
that these files don't come from an absolute path on the filesystem, but insead
come from URLs and can be referenced by relative path:

Source1:  https://github.com/maciejhirsz/logos/raw/v0.13/LICENSE-APACHE
Source2:  https://github.com/maciejhirsz/logos/raw/v0.13/LICENSE-MIT

Additionally, please don't mix tabs and spaces in spec files. And since
rust2rpm defaults to spaces, please use spaces for indenting. :)

Looks like you also made a small mistake when updating the %files list here:

> %files          devel
> %doc %{crate_instdir}/README.md
> %{crate_instdir}/
> %license %{crate_instdir}/LICENSE-APACHE
> %license %{crate_instdir}/LICENSE-MIT
> %{crate_instdir}/

The %{crate_instdir}/ should not be listed twice, it should be something like:

%files          devel
%license %{crate_instdir}/LICENSE-APACHE
%license %{crate_instdir}/LICENSE-MIT
%doc %{crate_instdir}/README.md
%{crate_instdir}/

This matches what rust2rpm would produce if the files were included in the
upstream sources.

Please also take care not to introduce additional whitespace / newlines when
making manual changes. They will only result in additional non-useful "diff"
output when updating the package in the future.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2245445

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245445%23c9
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux