https://bugzilla.redhat.com/show_bug.cgi?id=2246561 --- Comment #6 from blinxen <h-k-81@xxxxxxxxxxx> --- > - The "runtime/themes/*" contents are covered under different licenses - are they copied from different projects? According to themes README [1], some themes are user submissions. The others are probably ports from other projects. Do their license files also have to be installed? > I don't think they are included in the final package, but that needs to be verified. Exactly, the source files for the grammars are not included. They are only added to the helix tarball so we are able to build and add them in the final package. Or else the user has to do `hx --grammar fetch` and `hx --grammar build` after the initial installation (which I would like to prevent). > Especially bundling all the tree-sitter stuff (including some tree-sitter sources / headers themselves) looks very suspicious to me Well that goes back to how helix works. Language-specific settings and settings for language servers are configured in `languages.toml`. In that file, the grammars + their sources are also declared. Helix builds the specified version of the tree-sitter parsers and puts it in the configured runtime directory. The build step for the parsers can be skipped but helix needs the ".so" files to be in the runtime directory. So the only thing we can do here is either bundle them or package each tree-sitter parser and add a symlink of all ".so" files to the runtime directory. [1] https://github.com/helix-editor/helix/blob/master/runtime/themes/README.md [2] https://tree-sitter.github.io/tree-sitter/using-parsers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
