https://bugzilla.redhat.com/show_bug.cgi?id=2246718 --- Comment #6 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Spec use %global instead of %define unless justified. Ah, right. Will fix this. > lhasa.spec:61: W: unversioned-explicit-provides bundled(js-jquery) > If you can figure out which actual version this is using of jquery, it'd be good to add it here. The jQuery copy does not come from Lhasa source archive, but is rather inserted by Doxygen when it generates the HTML documentation. Hence, the version of jQuery depends on Doxygen and will change over time. I think it's better to leave this unversioned. > I see you have > > # Explicitly require libs in the main package > Requires: %{name}-libs%{?_isa} = %{version}-%{release} > > in the main package -- this shouldn't be needed as shared libraries are usually picked up automatically. If that isn't working properly, I'd expand on the comment and clarify why this is needed. Someone required this in a previous package review of mine. Looking at the packaging guidelines, I couldn't find any official requirement to have this. I guess one motivation to put that line may be so that the EVR of the main package and libs have to match - otherwise you can install an older/newer version of the libs package, as long as the SONAME matches. > In the %files for the library you have > %{_libdir}/liblhasa.so.* > which is too greedy -- you'll want %{_libdir}/liblhasa.so.0{,.*} instead. Right. Good point. Will change this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246718 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246718%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
