https://bugzilla.redhat.com/show_bug.cgi?id=2247020 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > BuildRequires: rust-packaging >= 23, systemd Ideally, build dependencies should be on their own lines. That makes it easier to observe in git diffs when dependencies change over time. It also looks like you only need the RPM macros, so you should change your "BuildRequires: systemd" to "BuildRequires: systemd-rpm-macros". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2247020 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247020%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue