https://bugzilla.redhat.com/show_bug.cgi?id=2246872 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |benson_muite@xxxxxxxxxxxxx --- Comment #1 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Initial comments: a) Can you reference the source: https://github.com/Setup-Tooling/Setup-Tool-for-Fedora See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags b) Probably do not want to hard code versions in: https://github.com/Setup-Tooling/Setup-Tool-for-Fedora/blob/stable/cli/setup-tool-cli.c c) use desktop-file-install https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files d) Add compiler flags: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags e) The tool may hide that one is installing packages from outside the main Fedora repositories. This may be undesirable. f) Replace %license %{_datadir}/licenses/setup-tool/LICENSE %doc %{_datadir}/doc/setup-tool/README.md with %license LICENSE %doc README.md They will be put in the correct locations g) Use cp -p or install -p -D755 or install -p -D644 to preserve timestamps. The install command allows setting of permissions. h) Use SPDX license identifier either MPL-2.0 https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246872 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246872%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
