https://bugzilla.redhat.com/show_bug.cgi?id=2246718 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _configure ./autogen.sh This is flagging the use of %define to make %configure run autogen.sh instead of configure. That's clever, and probably fine, but you may want to consider just running autoreconf -ivf before %configure explicitly for clarity instead. lhasa.spec:61: W: unversioned-explicit-provides bundled(js-jquery) If you can figure out which actual version this is using of jquery, it'd be good to add it here. I see you have # Explicitly require libs in the main package Requires: %{name}-libs%{?_isa} = %{version}-%{release} in the main package -- this shouldn't be needed as shared libraries are usually picked up automatically. If that isn't working properly, I'd expand on the comment and clarify why this is needed. In the %files for the library you have %{_libdir}/liblhasa.so.* which is too greedy -- you'll want %{_libdir}/liblhasa.so.0{,.*} instead. None of these are major issues and they can all be sorted out on import, so it's APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246718 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246718%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
