https://bugzilla.redhat.com/show_bug.cgi?id=2246777 --- Comment #6 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #5) > (In reply to Sandro from comment #4) > > That's an issue to be addressed with regards to `python-plotly`. This > > package doesn't ship any Javascript files. Although, it's rather useless > > without `plotly`, should that no longer be permissible. > > It ships them in the source RPM. If something in the source archive violates > packaging guidelines (like a precompiled executable), it’s enough to remove > it in %prep. If there’s something that means we can’t redistribute a file > from the source archive, we need to remove it before uploading to the > lookaside cache so it doesn’t appear either in the lookaside cache or in the > .src.rpm packages. Right. My bad. I forgot to take the SRPM and the tarballs in it into account. > In any case, they don’t cover the massive > dependency tree of https://github.com/plotly/plotly.js/, which is where the > plotly.min.js bundle seems to come from. There is some information in the repository and on the website regarding building and bundling from scratch ([1],[2],[3]). So, to make `python-plotly` compliant one would need to build `plotly.js` from scratch and package it for Fedora. This package (`python-chart-studio`) and `python-plotly-geo` could then be build from the PyPI source tarball, which do not contain any Javascript files. [1] https://github.com/plotly/plotly.js/blob/master/BUILDING.md [2] https://github.com/plotly/plotly.js/blob/master/CUSTOM_BUNDLE.md [3] https://github.com/plotly/plotly.js/blob/master/dist/README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246777 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246777%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
