https://bugzilla.redhat.com/show_bug.cgi?id=2244403 --- Comment #12 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the review! > Comments: > a) The Makefile is not used, so the sed command can be removed from the spec > file. Right. That's a leftover from when I still used `make`. But that was only for the linters, which have been eliminated. I'll clean that up. > b) pypy3 is not used, the makefile has it to run a test, but test with > cpython should be > sufficient, so can remove > BuildRequires: /usr/bin/pypy3 Ack. Another leftover to tidy up. Good catch! > c) The test does have a small output in the build log: > All tests passed :) Indeed. I wish all my tests were that easy to satisfy. ;) > d) You might choose to use %autochangelog if using %{autorelease} I already do. It is being expanded when Copr rebuilds the SRPM. > e) Approved. Changes a and b can be done upon import. Will do. Thank you again! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244403 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244403%23c12 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
