[Bug 2241608] Review Request: golang-github-jacobsa-oglemock - Mocking framework for Go inspired by Google Mock for C++ and Google JS Test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241608

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(zebob.m@xxxxxxxxx |needinfo?(loganjerry@gmail.
                   |)                           |com)



--- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
Thanks for the review!

- Note the files-duplicate warning from rpmlint below.  Doe we need README.md
  in both places?

No but I can't do anything about it, the go install process pics up .md files
automatically.


- The file sample/README.markdown is installed in /usr/share/doc, but it is
  confusing.  It starts "This directory contains sample code...", which is
  certainly not true of the directory containing README.markdown.  The sample
  code is installed, but it is in
  /usr/share/gocode/src/github.com/jacobsa/oglemock/sample.


Removed

Spec URL:
https://eclipseo.fedorapeople.org/for-review/golang-github-jacobsa-oglemock.spec
SRPM URL:
https://eclipseo.fedorapeople.org/for-review/golang-github-jacobsa-oglemock-0-0.1.20231001gite94d794.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2241608

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241608%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux