https://bugzilla.redhat.com/show_bug.cgi?id=2244402 --- Comment #7 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #6) > Information about what should be done in each section could be > clarified better in the build guidelines. For reference, see: > https://rpm-software-management.github.io/rpm/manual/spec.html """ %prep prepares the sources for building. This is where sources are unpacked and possible patches applied, and other similar activies could be performed. """ Isn't that exactly what I'm doing? That the sources are prepared using a Java tool shouldn't matter. It's still a preparation for the build to come. Since I need to run `%pyproject_buildrequires` before `%build`, I really don't see how I could move running the ant script to build. By the time I get there the script needs to be gone. We are building a Python package not a Java package. And the Python package lives in `ebcdic/`, which we move to the top level, so the Python RPM macros can do their magic. > https://docs.fedoraproject.org/en-US/java-packaging-howto/ > introduction_for_developers/ This isn't a Java package. It's merely using a Java tool for prepping the sources. I could not run ant at all. But that would result in an incomplete set of codecs. Yet the package would still build. > the %prep section is to unpack sources and apply patches. Running existing > programs > that modify the sources such as iconv is often done, but other commands > associated with setting up the build environment such as using cmake, > autotools etc. > are done in build sections. > > Compiling code is best done in the %build section as a cleanable > directory hierarchy is created for that purpose. Need to go through: > https://github.com/rpm-software-management/rpm/blob/master/tools/rpmbuild.c > in more detail. That's going into the nitty-gritty of RPM itself. I was looking more for a section in the Fedora Packaging Guidelines saying that what I do MUST not be done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244402 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244402%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
