https://bugzilla.redhat.com/show_bug.cgi?id=2215421 Jos de Kloe <josdekloe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Jos de Kloe <josdekloe@xxxxxxxxx> --- > I honestly have no idea where this comment is coming from. The package BRs pkgconfig(openssl), which on rawhide brings in: > openssl-devel x86_64 1:3.1.1-4.fc40 fedora 2.6 M > Although the binaries don't require either of libcrypto or libssl so I'm not entirely sure it's used, despite being checked for: > checking for openssl... yes > I see no evidence of openssl1.1-devel being involved. I agree, it seems not used. At least ldd does not show that libssl is loaded by the x2gokdrive executable. > According to https://docs.fedoraproject.org/en-US/legal/license-field/: > The spec file License tag consists of an enumeration of all licenses covering any code or other material contained in the corresponding binary > RPM. This enumeration must take the form of an SPDX license expression. No further analysis as to the "effective" license should be done. Explanation accepted. >> -rpmspec complains about permissions of the source files. >> please fix this. >Fixed. Thanks. You addressed all my remarks, therefore this package is now approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2215421 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215421%23c11 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
