https://bugzilla.redhat.com/show_bug.cgi?id=2246225 --- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Carl George 🤠 from comment #5) > The /usr/bin/lsb_release path in this package conflicts with the same path > in redhat-lsb-core. Implicit conflicts are not allowed. I don't expect > either upstream will rename as the third party tools often require the > lsb_release command specifically, so you need to add an explicit `Conflicts: > redhat-lsb-core` line. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/ > #_acceptable_uses_of_conflicts > Addressed. > ============================================================================= > === > > Add a comment above the patch to describe the upstream status. This could > be a link to an upstream bug report, pull request, or commit. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > PatchUpstreamStatus/ > Addressed. > ============================================================================= > === > > Optionally, you can use %make_build and %make_install instead of calling > make directly. The parallel aspect isn't strictly required since this is a > noarch package, but it is still best practice in case any other default > flags are ever added to %make_build. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_why_the_makeinstall_macro_should_not_be_used > > ============================================================================= > === > > Optionally, you can use Source and Patch (unnumbered), which works all the > back to EL9. > > ============================================================================= > === > Skipping these. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246225 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246225%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
