https://bugzilla.redhat.com/show_bug.cgi?id=2241620 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ Hmmmm, fedora-review came up with this issue on its own. The funny thing is that I do not see openssl1.1-devel in root.log, so it wasn't even installed. I suspect that fedora-review saw that this package BuildRequires both pkgconfig(libcrypto) and pkgconfig(openssl), and saw that openssl1.1-devel, a deprecated package, Provides both of those. Well, openssl-devel Provides them, too. I'm not sure what the right thing to do is here. Perhaps this package should BuildRequires: openssl-devel explicitly to be sure that openssl1.1-devel can't be used to fulfill the BuildRequires? - Can you remove /usr/share/doc/gocryptfs/Documentation/.gitignore from the binary package? I don't see why MANPAGE-render.bash should be there either. Both files are also in golang-github-rfjakob-gocryptfs-devel. - There are man pages in /usr/share/doc/gocryptfs/Documentation. Some are also in /usr/share/man/man1, and some aren't. Shouldn't they all be there instead of in the Documentation directory? The man pages are also in the golang-github-rfjakob-gocryptfs-devel, which doesn't seem right since that package contains no binaries. - There are no debuginfo or debugsource packages for the gocryptfs package, which contains binaries. Shouldn't there be? ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 559702 bytes in 40 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gocryptfs-2.4.0-1.fc40.x86_64.rpm golang-github-rfjakob-gocryptfs-devel-2.4.0-1.fc40.noarch.rpm gocryptfs-2.4.0-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfbebc_55')] checks: 31, packages: 3 gocryptfs.x86_64: E: version-control-internal-file /usr/share/doc/gocryptfs/Documentation/.gitignore golang-github-rfjakob-gocryptfs-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/.gitignore gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/atomicrename gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/findholes gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/gocryptfs gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/gocryptfs-xray gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/statfs gocryptfs.x86_64: W: no-manual-page-for-binary atomicrename gocryptfs.x86_64: W: no-manual-page-for-binary findholes gocryptfs.x86_64: W: no-manual-page-for-binary statfs golang-github-rfjakob-gocryptfs-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/rfjakob/gocryptfs/.goipath golang-github-rfjakob-gocryptfs-devel.noarch: E: files-duplicated-waste 129838 golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/CLI_ABI.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/CLI_ABI.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/MANPAGE-STATFS.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/MANPAGE-STATFS.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/MANPAGE-XRAY.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/MANPAGE-XRAY.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/MANPAGE.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/MANPAGE.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/SECURITY.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/SECURITY.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/XFSTESTS.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/XFSTESTS.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/extractloop.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/extractloop.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/file-format.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/file-format.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/README.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/README.md ================ 3 packages and 0 specfiles checked; 3 errors, 18 warnings, 3 badness; has taken 0.5 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 golang-github-rfjakob-gocryptfs-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/.gitignore gocryptfs.x86_64: E: version-control-internal-file /usr/share/doc/gocryptfs/Documentation/.gitignore gocryptfs.x86_64: W: unused-direct-shlib-dependency /usr/bin/gocryptfs /lib64/libresolv.so.2 gocryptfs.x86_64: W: unused-direct-shlib-dependency /usr/bin/gocryptfs-xray /lib64/libresolv.so.2 gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/atomicrename gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/findholes gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/gocryptfs gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/gocryptfs-xray gocryptfs.x86_64: W: unstripped-binary-or-object /usr/bin/statfs gocryptfs.x86_64: W: no-manual-page-for-binary atomicrename gocryptfs.x86_64: W: no-manual-page-for-binary findholes gocryptfs.x86_64: W: no-manual-page-for-binary statfs golang-github-rfjakob-gocryptfs-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/rfjakob/gocryptfs/.goipath golang-github-rfjakob-gocryptfs-devel.noarch: E: files-duplicated-waste 129838 golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/CLI_ABI.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/CLI_ABI.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/MANPAGE-STATFS.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/MANPAGE-STATFS.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/MANPAGE-XRAY.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/MANPAGE-XRAY.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/MANPAGE.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/MANPAGE.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/SECURITY.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/SECURITY.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/XFSTESTS.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/XFSTESTS.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/extractloop.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/extractloop.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/Documentation/file-format.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/Documentation/file-format.md golang-github-rfjakob-gocryptfs-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/rfjakob/gocryptfs/README.md /usr/share/doc/golang-github-rfjakob-gocryptfs-devel/README.md 2 packages and 0 specfiles checked; 3 errors, 20 warnings, 3 badness; has taken 0.4 s Source checksums ---------------- https://github.com/rfjakob/gocryptfs/archive/v2.4.0/gocryptfs-2.4.0.tar.gz : CHECKSUM(SHA256) this package : a36d47f546b7deb87e291066a09d324015dbada123de355f41d035ba7a9d6b2b CHECKSUM(SHA256) upstream package : a36d47f546b7deb87e291066a09d324015dbada123de355f41d035ba7a9d6b2b Requires -------- gocryptfs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) golang-github-rfjakob-gocryptfs-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/aperturerobotics/jacobsa-crypto/siv) golang(github.com/hanwen/go-fuse/v2/fs) golang(github.com/hanwen/go-fuse/v2/fuse) golang(github.com/rfjakob/eme) golang(github.com/sabhiram/go-gitignore) golang(github.com/spf13/pflag) golang(golang.org/x/crypto/chacha20) golang(golang.org/x/crypto/chacha20poly1305) golang(golang.org/x/crypto/hkdf) golang(golang.org/x/crypto/scrypt) golang(golang.org/x/sys/cpu) golang(golang.org/x/sys/unix) golang(golang.org/x/term) Provides -------- gocryptfs: gocryptfs gocryptfs(x86-64) golang-github-rfjakob-gocryptfs-devel: golang(github.com/rfjakob/gocryptfs/contrib/findholes/holes) golang(github.com/rfjakob/gocryptfs/ctlsock) golang(github.com/rfjakob/gocryptfs/internal/configfile) golang(github.com/rfjakob/gocryptfs/internal/contentenc) golang(github.com/rfjakob/gocryptfs/internal/cryptocore) golang(github.com/rfjakob/gocryptfs/internal/ctlsocksrv) golang(github.com/rfjakob/gocryptfs/internal/ensurefds012) golang(github.com/rfjakob/gocryptfs/internal/exitcodes) golang(github.com/rfjakob/gocryptfs/internal/fido2) golang(github.com/rfjakob/gocryptfs/internal/fusefrontend) golang(github.com/rfjakob/gocryptfs/internal/fusefrontend_reverse) golang(github.com/rfjakob/gocryptfs/internal/inomap) golang(github.com/rfjakob/gocryptfs/internal/nametransform) golang(github.com/rfjakob/gocryptfs/internal/openfiletable) golang(github.com/rfjakob/gocryptfs/internal/pathiv) golang(github.com/rfjakob/gocryptfs/internal/readpassword) golang(github.com/rfjakob/gocryptfs/internal/siv_aead) golang(github.com/rfjakob/gocryptfs/internal/speed) golang(github.com/rfjakob/gocryptfs/internal/stupidgcm) golang(github.com/rfjakob/gocryptfs/internal/syscallcompat) golang(github.com/rfjakob/gocryptfs/internal/tlog) golang(github.com/rfjakob/gocryptfs/tests/matrix) golang(github.com/rfjakob/gocryptfs/tests/test_helpers) golang-github-rfjakob-gocryptfs-devel golang-ipath(github.com/rfjakob/gocryptfs) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2241620 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-eclipseo Active plugins: C/C++, Generic, Shell-api Disabled plugins: fonts, PHP, Perl, Ocaml, SugarActivity, Ruby, Java, R, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241620 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241620%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
