Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libXfontcache https://bugzilla.redhat.com/show_bug.cgi?id=226072 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-01-13 02:49 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint output is ok to accept libXfontcache.i386: W: obsolete-not-provided XFree86-libs libXfontcache.i386: W: obsolete-not-provided xorg-x11-libs libXfontcache.src:18: W: unversioned-explicit-obsoletes XFree86-libs libXfontcache.src:18: W: unversioned-explicit-obsoletes xorg-x11-libs libXfontcache.src:31: W: unversioned-explicit-obsoletes XFree86-devel libXfontcache.src:31: W: unversioned-explicit-obsoletes xorg-x11-devel libXfontcache-devel.i386: W: obsolete-not-provided XFree86-devel libXfontcache-devel.i386: W: obsolete-not-provided xorg-x11-devel + source match upstream 1adca018aa7bf2d215f20a69c10828ad libXfontcache-1.0.4.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + xfontcache.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + Package libXfontcache-1.0.4-4.fc9 => Provides: libXfontcache.so.1 Requires: libX11.so.6 libXext.so.6 libXfontcache.so.1 libc.so.6 libc.so.6(GLIBC_2.1.3) rtld(GNU_HASH) + Package libXfontcache-devel-1.0.4-4.fc9 => Requires(pre): xorg-x11-filesystem >= 0.99.2-3 Requires: libXfontcache = 1.0.4-4.fc9 libXfontcache.so.1 pkgconfig xorg-x11-proto-devel + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review