https://bugzilla.redhat.com/show_bug.cgi?id=2245909 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #3 from Davide Cavalca <davide@xxxxxxxxxxxx> --- This looks fine overall, my only recommendation would be to not use the forge macros, as they put the snapshot string (20231023git783cb74) in the Release, while policy recommends putting this in Version (see https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots). APPROVED, as this is still allowed, just noted as deprecated, so consider fixing it on import -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2245909 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245909%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
