[Bug 2232847] Review Request: deepin-wayland-protocols - Deepin Specific Protocols for Wayland

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2232847

Felix Wang <topazus@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |topazus@xxxxxxxxxxx
                 CC|                            |topazus@xxxxxxxxxxx
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED



--- Comment #4 from Felix Wang <topazus@xxxxxxxxxxx> ---
Take this. Besides the above Tim's comments, Here are my comments.

1. It would be better to put the files in the -devel sub-package, like the
wayland-protocols package,
https://src.fedoraproject.org/rpms/wayland-protocols/blob/rawhide/f/wayland-protocols.spec

2.
> The %{name}-devel package contains libraries and header files
> for developing applications that use %{name}.


The description is not appropriate to express the package.

3.
> BuildRequires:  qt5-qtbase-devel

I see the CMake files in the project, it seems that the package do not have
this build dependency.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2232847

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232847%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux